Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] Backport to 3.11: Upgrade to Hibernate ORM 6.5.2 and configure Hibernate ORM/Reactive with database product names instead of dialect names for core dialects #40675

Merged
merged 5 commits into from
May 21, 2024

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented May 16, 2024

Creating now as draft, but the ORM 6.5.2 release hasn't happened yet.

Fixes #37575

Backport of #40474 and #40674

Content of the upgrade:

https://hibernate.atlassian.net/issues/?jql=project%20%3D%20HHH%20AND%20fixVersion%20in%20(6.5.1,6.5.2)%20ORDER%20BY%20updated

6.5.1:

https://hibernate.atlassian.net/browse/HHH-18112 Some dialects use the wrong default version
https://hibernate.atlassian.net/browse/HHH-17421 On SQL Server, combining DISTINCT with PESSIMISTIC_WRITE causes needless follow-on locking
https://hibernate.atlassian.net/browse/HHH-18011 Parallel entity enhancement causes a classloader cache stampede
https://hibernate.atlassian.net/browse/HHH-17305 Keep order of selected tables in polymorphic query
https://hibernate.atlassian.net/browse/HHH-18094 Bytebuddy enhancer: make better use of constants and memory
https://hibernate.atlassian.net/browse/HHH-18032 CompositeId, when the id assigned by PrePersist method an HibernateException: identifier of an instance of _ was altered is thrown
https://hibernate.atlassian.net/browse/HHH-17827 “Not a managed type” error when using entity interface extending from java.util.Map
https://hibernate.atlassian.net/browse/HHH-17837 Join + GroupBy: Wrong column used for many-to-many association
https://hibernate.atlassian.net/browse/HHH-17834 lock(e, OPTIMISTIC_FORCE_INCREMENT) with TABLE_PER_SUBCLASS
https://hibernate.atlassian.net/browse/HHH-18091 Upgrade to ByteBuddy 1.14.15
https://hibernate.atlassian.net/browse/HHH-18080 hibernate.boot.allow_jdbc_metadata_access=false leads to warning about "0.0.0 version"
https://hibernate.atlassian.net/browse/HHH-18046 DB2 numeric parameter arithmetic issue
https://hibernate.atlassian.net/browse/HHH-18018 Derby implementation for 'right' function wrongly passes parameter to 'length'

6.5.2:

HHH-18112 Some dialects use the wrong default version
HHH-18026 Prevent dialects not supporting arbitrary values retrieval in getGeneratedKeys() from logging a SQL exception

dependabot bot and others added 5 commits May 16, 2024 10:43
Bumps `hibernate-orm.version` from 6.5.0.Final to 6.5.1.Final.

Updates `org.hibernate.orm:hibernate-core` from 6.5.0.Final to 6.5.1.Final
- [Release notes](https://github.com/hibernate/hibernate-orm/releases)
- [Changelog](https://github.com/hibernate/hibernate-orm/blob/6.5.1/changelog.txt)
- [Commits](hibernate/hibernate-orm@6.5.0...6.5.1)

Updates `org.hibernate.orm:hibernate-graalvm` from 6.5.0.Final to 6.5.1.Final
- [Release notes](https://github.com/hibernate/hibernate-orm/releases)
- [Changelog](https://github.com/hibernate/hibernate-orm/blob/6.5.1/changelog.txt)
- [Commits](hibernate/hibernate-orm@6.5.0...6.5.1)

Updates `org.hibernate.orm:hibernate-envers` from 6.5.0.Final to 6.5.1.Final
- [Release notes](https://github.com/hibernate/hibernate-orm/releases)
- [Changelog](https://github.com/hibernate/hibernate-orm/blob/6.5.1/changelog.txt)
- [Commits](hibernate/hibernate-orm@6.5.0...6.5.1)

Updates `org.hibernate.orm:hibernate-jpamodelgen` from 6.5.0.Final to 6.5.1.Final
- [Release notes](https://github.com/hibernate/hibernate-orm/releases)
- [Changelog](https://github.com/hibernate/hibernate-orm/blob/6.5.1/changelog.txt)
- [Commits](hibernate/hibernate-orm@6.5.0...6.5.1)

Updates `org.hibernate:hibernate-jpamodelgen` from 6.5.0.Final to 6.5.1.Final
- [Release notes](https://github.com/hibernate/hibernate-orm/releases)
- [Changelog](https://github.com/hibernate/hibernate-orm/blob/6.5.1/changelog.txt)
- [Commits](hibernate/hibernate-orm@6.5.0...6.5.1)

Updates `org.hibernate.orm:hibernate-community-dialects` from 6.5.0.Final to 6.5.1.Final
- [Release notes](https://github.com/hibernate/hibernate-orm/releases)
- [Changelog](https://github.com/hibernate/hibernate-orm/blob/6.5.1/changelog.txt)
- [Commits](hibernate/hibernate-orm@6.5.0...6.5.1)

---
updated-dependencies:
- dependency-name: org.hibernate.orm:hibernate-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.hibernate.orm:hibernate-graalvm
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.hibernate.orm:hibernate-envers
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.hibernate.orm:hibernate-jpamodelgen
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.hibernate:hibernate-jpamodelgen
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.hibernate.orm:hibernate-community-dialects
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…of dialect names for core dialects

Mainly to avoid Hibernate ORM logging warnings on startup.
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive area/persistence OBSOLETE, DO NOT USE labels May 16, 2024
Copy link

quarkus-bot bot commented May 16, 2024

/cc @gsmet (hibernate-orm)

@quarkus-bot quarkus-bot bot changed the title Backport to 3.11: Upgrade to Hibernate ORM 6.5.2 and configure Hibernate ORM/Reactive with database product names instead of dialect names for core dialects [3.11] Backport to 3.11: Upgrade to Hibernate ORM 6.5.2 and configure Hibernate ORM/Reactive with database product names instead of dialect names for core dialects May 16, 2024
@yrodiere yrodiere marked this pull request as ready for review May 21, 2024 07:29
@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 21, 2024
Copy link

quarkus-bot bot commented May 21, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 3782329.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 Failures Logs Raw logs 🔍
✔️ JVM Tests - JDK 21 Logs Raw logs 🚧

You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/reactive-mssql-client/deployment 
! Skipped: integration-tests/reactive-mssql-client 

📦 extensions/reactive-mssql-client/deployment

Failed to execute goal io.fabric8:docker-maven-plugin:0.44.0:start (docker-start) on project quarkus-reactive-mssql-client-deployment: I/O Error


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.OpenTelemetrySpanSecurityEventsTest.testSecurityEventTypes - History

  • event executor terminated - java.util.concurrent.RejectedExecutionException
java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:934)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:351)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:344)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:836)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:827)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:817)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

@gsmet gsmet merged commit 1b42a51 into quarkusio:3.11 May 21, 2024
65 checks passed
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive area/persistence OBSOLETE, DO NOT USE kind/bugfix triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants